Home page transaction entry #198

Sirmorrison · 2023-10-21T13:17:35Z

fix #180

dreacot · 2023-10-23T17:21:13Z

this should be a wallet dropdown selector

i should be able to select the wallet i want to view transactions for

dreacot · 2023-10-23T17:23:28Z

clicking on a tx causes a crash

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x12e424c]

goroutine 181 [running]:
github.com/crypto-power/cryptopower/ui/page/transaction.NewTransactionDetailsPage(0xc0043f7c20, 0xc005180000, 0x18?)
        /home/kennedy/Projects/src/github.com/cryptopower/cryptopower/ui/page/transaction/transaction_details_page.go:121 +0xd4c
github.com/crypto-power/cryptopower/ui/page/transaction.(*TransactionsPage).HandleUserInteractions(0xc0005b2370)
        /home/kennedy/Projects/src/github.com/cryptopower/cryptopower/ui/page/transaction/transactions_page.go:413 +0xd6
github.com/crypto-power/cryptopower/ui/page/root.(*HomePage).HandleUserInteractions(0xc000004f00)
        /home/kennedy/Projects/src/github.com/cryptopower/cryptopower/ui/page/root/home_page.go:186 +0x67
github.com/crypto-power/cryptopower/ui.(*Window).handleFrameEvent(0xc000189860, {{0xc145c8d933aa1f39, 0x2ad18a474f, 0x2ebb220}, {0x3f800000, 0x3f800000}, {0x320, 0x28a}, {0x0, 0x0, ...}, ...})
        /home/kennedy/Projects/src/github.com/cryptopower/cryptopower/ui/window.go:233 +0x14c
github.com/crypto-power/cryptopower/ui.(*Window).HandleEvents(0xc000189860)
        /home/kennedy/Projects/src/github.com/cryptopower/cryptopower/ui/window.go:206 +0x2b9
main.main.func3()
        /home/kennedy/Projects/src/github.com/cryptopower/cryptopower/main.go:110 +0x1d
created by main.main
        /home/kennedy/Projects/src/github.com/cryptopower/cryptopower/main.go:108 +0x61b
exit status 2

JustinBeBoy · 2023-10-24T17:30:21Z

app stuck when change filter to sent.

Transferred notice "(0)" but we have data on list.

the same above

"All" filter notice 2 but empty in list

JustinBeBoy · 2023-10-24T17:34:29Z

The right margin needs alignment

JustinBeBoy · 2023-10-24T17:38:35Z

App stuck when switch between wallets

Please warn users when choosing a wallet that is not synchronized like this:

dreacot · 2023-10-24T17:39:03Z

we don't need to show the wallet balance, this is simply a wallet dropdown

we had something like this in godcr

selecting the wallet should be a dropdown not open a modal, see the screenshot above

dreacot · 2023-10-24T17:41:38Z

staking activity doesn't show when selected on the tx page inside a selected wallet

Sirmorrison · 2023-10-26T08:10:02Z

app stuck when change filter to sent.

Transferred notice "(0)" but we have data on list.

the same above

"All" filter notice 2 but empty in list

I could not reproduce the part where the app gets stuck besides that, I attended to all other comments.

JustinBeBoy · 2023-10-26T13:00:01Z

Layout break when choose not synced wallet

JustinBeBoy · 2023-10-26T13:01:12Z

The right margin needs alignment

it not resolve

JustinBeBoy

please check my comments

Sirmorrison · 2023-10-26T13:49:04Z

Layout break when choose not synced wallet

By layout break, how do you mean? If you mean you just see the red text, thats the design because we cannot using the overlay would involve changing how the overlay is displayed from a selected wallet view.

JustinBeBoy · 2023-10-26T13:52:42Z

Layout break when choose not synced wallet

By layout break, how do you mean? If you mean you just see the red text, thats the design because we cannot using the overlay would involve changing how the overlay is displayed from a selected wallet view.

Sorry, I mean tab's title not center when choose not sync wallet

Sirmorrison · 2023-10-26T13:53:20Z

The right margin needs alignment

it not resolve

This is as a result of the scroll list.. there is an extra padding for the scroll bar. I will see if i can adjust it as its currently on master not my PR.

JustinBeBoy · 2023-10-26T17:40:08Z

The right margin needs alignment

it not resolve

This is as a result of the scroll list.. there is an extra padding for the scroll bar. I will see if i can adjust it as its currently on master not my PR.

I think we should do it on this PR, so it will be perfect

dreacot · 2023-10-26T18:17:16Z

why not make use of the existing overlay for this situation

dreacot · 2023-10-26T18:18:47Z

i was on the revocation dropdown on the staking segmented control, switching the segmented control to transaction overview, showed the error seen in the screenshot below

and then after clicking okay, the loader just keep showing as seen below

dreacot · 2023-10-26T18:26:16Z

trying to switch the wallet selector freezes the app

Sirmorrison · 2023-10-27T18:37:57Z

trying to switch the wallet selector freezes the app

I am unable to reproduce this.

Sirmorrison · 2023-10-27T18:39:06Z

i was on the revocation dropdown on the staking segmented control, switching the segmented control to transaction overview, showed the error seen in the screenshot below

and then after clicking okay, the loader just keep showing as seen below

resolved

why not make use of the existing overlay for this situation

Resolved

The right margin needs alignment

it not resolve

This is as a result of the scroll list.. there is an extra padding for the scroll bar. I will see if i can adjust it as its currently on master not my PR.

I think we should do it on this PR, so it will be perfect

resolved

dreacot · 2023-10-29T20:29:47Z

the transaction item isn't showing the correct wallet name

dreacot · 2023-10-29T20:36:43Z

trying to switch the wallet selector freezes the app

I am unable to reproduce this.

i'd get a screen recording, this happens when i select wallets of different assets from the dropdown about 4 times in a row

dreacot · 2023-10-29T20:46:23Z

trying to switch the wallet selector freezes the app

I am unable to reproduce this.

i'd get a screen recording, this happens when i select wallets of different assets from the dropdown about 4 times in a row

Screen.Recording.2023-10-29.at.2.44.43.PM.mov

dreacot · 2023-10-29T20:50:48Z

trying to switch the wallet selector freezes the app

I am unable to reproduce this.

i'd get a screen recording, this happens when i select wallets of different assets from the dropdown about 4 times in a row

Screen.Recording.2023-10-29.at.2.44.43.PM.mov

seems like this occurs when btc goes into recovery mode, might not be directly related to this PR

JustinBeBoy · 2023-11-01T17:04:15Z

I still stuck when change tab to Staking Activities
I think it occurs when you have many transactions. I have 5 time. It always occurs

JustinBeBoy · 2023-11-01T17:07:30Z

I have 2 Revocation when select all filter. but when select Revocation it show only one

- Fix error message when tabs are changed from staking to tx. - Use inactive overlay is wallet is not synced - clean up

Sirmorrison · 2023-11-26T20:05:59Z

follow up PR #268

…aoding multi wallet txs

itswisdomagain · 2023-11-27T09:14:07Z

ui/cryptomaterial/dropdown.go

+	clickable := d.clickable
+	if d.isOpen {
+		radius = Radius(0)
+		if item.clickable != nil {


Are you basically saying that item cannot be nil if d.isOpen?
Because in line 159-162 above, we only give item a value if itemIndex > -1. So if itemIndex is -1, item will be nil.

And this point where you do if item.clickable != nil will panic. Unless d.isOpen is only true if itemIndex > -1.

itswisdomagain · 2023-11-27T09:14:41Z

ui/cryptomaterial/dropdown.go

+	clickable := d.clickable
+	if d.isOpen {
+		radius = Radius(0)
+		if item.clickable != nil {


All Possible areas where items could panic was addressed.

I don't see where this is done. Point me to it.

ui/cryptomaterial/dropdown.go

ui/page/components/components.go

ui/page/transaction/transactions_page.go

itswisdomagain

I'm yet to fully test but the code changes look okay now. Just these 2 comments.

ui/page/components/items_scroll.go

ui/page/transaction/transactions_page.go

Sirmorrison force-pushed the txh branch from 065b6d9 to 8ed4b65 Compare October 24, 2023 06:13

Sirmorrison force-pushed the txh branch from 8ed4b65 to 8938ee5 Compare October 26, 2023 08:08

JustinBeBoy previously requested changes Oct 26, 2023

View reviewed changes

Sirmorrison force-pushed the txh branch from a9b4689 to 8532118 Compare November 1, 2023 08:16

dreacot approved these changes Nov 1, 2023

View reviewed changes

Sirmorrison added 13 commits November 24, 2023 18:02

Fix excess right padding

5f4a18b

- Fix error message when tabs are changed from staking to tx. - Use inactive overlay is wallet is not synced - clean up

remove asset name

f4b3982

rebase pr

e31f617

conditionally display segment and wallet selector, code clean up

f53eec4

code clean up and optimzation

28e6b2a

pr rebase

4d2227b

implement wallet txs fetching

c1b1bd3

set default wallet dropdown selection to none, fix staking crash

f8108f0

rebase pr

fdd3fc5

fix lint error

97c0c53

code clean up review

022384e

rebase pr

ae82974

fix lint error

f23cac8

Sirmorrison force-pushed the txh branch 6 times, most recently from fb297ff to decde53 Compare November 26, 2023 19:27

Sirmorrison mentioned this pull request Nov 26, 2023

Improve infinite scroll list functionality #268

Closed

implement partial infinite scroll to prevent app from freezing when l…

8bf5dfe

…aoding multi wallet txs

Sirmorrison force-pushed the txh branch from decde53 to 8bf5dfe Compare November 26, 2023 20:07

itswisdomagain requested changes Nov 27, 2023

View reviewed changes

further code clean up

3b9eef7

itswisdomagain approved these changes Nov 28, 2023

View reviewed changes

ui/page/components/items_scroll.go Outdated Show resolved Hide resolved

ui/page/transaction/transactions_page.go Outdated Show resolved Hide resolved

Sirmorrison added 2 commits November 28, 2023 11:10

remove redunant lines of code

ac1dda4

revert changes

094899d

dreacot approved these changes Nov 28, 2023

View reviewed changes

dreacot merged commit c2c43af into crypto-power:master Nov 28, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Home page transaction entry #198

Home page transaction entry #198

Sirmorrison commented Oct 21, 2023 •

edited

Loading

dreacot commented Oct 23, 2023 •

edited

Loading

dreacot commented Oct 23, 2023 •

edited

Loading

JustinBeBoy commented Oct 24, 2023

JustinBeBoy commented Oct 24, 2023

JustinBeBoy commented Oct 24, 2023

dreacot commented Oct 24, 2023

dreacot commented Oct 24, 2023 •

edited

Loading

Sirmorrison commented Oct 26, 2023

JustinBeBoy commented Oct 26, 2023

JustinBeBoy commented Oct 26, 2023

JustinBeBoy left a comment

Sirmorrison commented Oct 26, 2023 •

edited

Loading

JustinBeBoy commented Oct 26, 2023

Sirmorrison commented Oct 26, 2023

JustinBeBoy commented Oct 26, 2023

dreacot commented Oct 26, 2023

dreacot commented Oct 26, 2023 •

edited

Loading

dreacot commented Oct 26, 2023

Sirmorrison commented Oct 27, 2023

Sirmorrison commented Oct 27, 2023

dreacot commented Oct 29, 2023

dreacot commented Oct 29, 2023

dreacot commented Oct 29, 2023

dreacot commented Oct 29, 2023

JustinBeBoy commented Nov 1, 2023

JustinBeBoy commented Nov 1, 2023

Sirmorrison commented Nov 26, 2023

itswisdomagain Nov 27, 2023

itswisdomagain Nov 27, 2023

itswisdomagain left a comment

Home page transaction entry #198

Home page transaction entry #198

Conversation

Sirmorrison commented Oct 21, 2023 • edited Loading

dreacot commented Oct 23, 2023 • edited Loading

dreacot commented Oct 23, 2023 • edited Loading

JustinBeBoy commented Oct 24, 2023

JustinBeBoy commented Oct 24, 2023

JustinBeBoy commented Oct 24, 2023

dreacot commented Oct 24, 2023

dreacot commented Oct 24, 2023 • edited Loading

Sirmorrison commented Oct 26, 2023

JustinBeBoy commented Oct 26, 2023

JustinBeBoy commented Oct 26, 2023

JustinBeBoy left a comment

Choose a reason for hiding this comment

Sirmorrison commented Oct 26, 2023 • edited Loading

JustinBeBoy commented Oct 26, 2023

Sirmorrison commented Oct 26, 2023

JustinBeBoy commented Oct 26, 2023

dreacot commented Oct 26, 2023

dreacot commented Oct 26, 2023 • edited Loading

dreacot commented Oct 26, 2023

Sirmorrison commented Oct 27, 2023

Sirmorrison commented Oct 27, 2023

dreacot commented Oct 29, 2023

dreacot commented Oct 29, 2023

dreacot commented Oct 29, 2023

dreacot commented Oct 29, 2023

JustinBeBoy commented Nov 1, 2023

JustinBeBoy commented Nov 1, 2023

Sirmorrison commented Nov 26, 2023

itswisdomagain Nov 27, 2023

Choose a reason for hiding this comment

itswisdomagain Nov 27, 2023

Choose a reason for hiding this comment

itswisdomagain left a comment

Choose a reason for hiding this comment

Sirmorrison commented Oct 21, 2023 •

edited

Loading

dreacot commented Oct 23, 2023 •

edited

Loading

dreacot commented Oct 23, 2023 •

edited

Loading

dreacot commented Oct 24, 2023 •

edited

Loading

Sirmorrison commented Oct 26, 2023 •

edited

Loading

dreacot commented Oct 26, 2023 •

edited

Loading