Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setup page #219

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Add setup page #219

merged 4 commits into from
Dec 6, 2023

Conversation

Vanvians
Copy link
Collaborator

Closes #142

Adds setup page in onboarding process

@Vanvians Vanvians marked this pull request as ready for review October 31, 2023 02:08
dreacot
dreacot requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Figma design]
Screenshot from 2023-10-31 10-02-40

  1. clicking on this should provide a blue outline as per the figma design above

Screenshot from 2023-10-31 10-01-36

  1. the back arrow as seen on figma is a chevron

Screenshot from 2023-10-31 10-03-25

  1. hovering on the card blends into the background, disable hover, or change the over background colour

Screenshot from 2023-10-31 10-04-49

  1. adjust the dropdown positioning when opened

Screenshot from 2023-10-31 10-05-23

ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
@Vanvians Vanvians force-pushed the startup_settings branch 2 times, most recently from 3aa1677 to 3edebe7 Compare November 1, 2023 03:30
JustinBeBoy
JustinBeBoy requested changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@JustinBeBoy JustinBeBoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think dropdown work like this, list item should under Language line

image

ui/page/start_page.go Outdated Show resolved Hide resolved
@JustinBeBoy
Copy link
Collaborator

  1. I have selected French language but when check it again it is always English, additional when user selected language all text need change to that language
    image

  2. I think user need to select type of setting before click button next.
    image

@dreacot
Copy link
Member

dreacot commented Nov 6, 2023

add a screenshot to this PR

Sirmorrison
Sirmorrison suggested changes Nov 23, 2023
View reviewed changes
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
Sirmorrison
Sirmorrison suggested changes Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
Sirmorrison
Sirmorrison suggested changes Nov 28, 2023
View reviewed changes
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
ui/page/start_page.go Outdated Show resolved Hide resolved
@Sirmorrison
Copy link
Collaborator

None of the comments marked as resolved were actually resolved.. or maybe you have not pushed. Kindly check.

@ukane-philemon
Copy link
Collaborator

Changes in: 9d3dffc

Note to reviewers: Language setting and the other setting options are not handled in this PR.

Screen.Recording.2023-12-06.at.2.03.59.AM.mov

Figma:

Screen.Recording.2023-12-06.at.2.05.16.AM.mov

@dreacot
Copy link
Member

dreacot commented Dec 6, 2023

Note to reviewers: Language setting and the other setting options are not handled in this PR.

why not?

@ukane-philemon
Copy link
Collaborator

Note to reviewers: Language setting and the other setting options are not handled in this PR.

why not?

I don't know what "Recommended" && "Advanced" are supposed to do when either of them is selected, is there a requirement?

@dreacot
Copy link
Member

dreacot commented Dec 6, 2023

Note to reviewers: Language setting and the other setting options are not handled in this PR.

why not?

I don't know what "Recommended" && "Advanced" are supposed to do when either of them is selected, is there a requirement?

okay follow up PR is fine

@dreacot dreacot merged commit ba2ca32 into crypto-power:master Dec 6, 2023
1 check passed
@dreacot
Copy link
Member

dreacot commented Dec 6, 2023

Note to reviewers: Language setting and the other setting options are not handled in this PR.

why not?

I don't know what "Recommended" && "Advanced" are supposed to do when either of them is selected, is there a requirement?

okay follow up PR is fine

see follow up here #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sirmorrison Sirmorrison Sirmorrison requested changes

@JustinBeBoy JustinBeBoy JustinBeBoy requested changes

@dreacot dreacot dreacot approved these changes

@ukane-philemon ukane-philemon Awaiting requested review from ukane-philemon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show page on app startup to help users choose their settings
5 participants
@Vanvians @JustinBeBoy @dreacot @Sirmorrison @ukane-philemon