Add slide action to slider and Update layout on overview page #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to slider, update logic click to indicator on slider
JustinBeBoy
changed the title
what does the sliding require a display layout to work? |
As a standalone component, it can be integrated into any layout. Consider integrating into layout with horizontal scrolling actions |
|
slide action, doesn't work for segmented control Screencast.from.2023-11-22.13.55.04.webm |
dreacot
reviewed
Nov 22, 2023
dreacot
reviewed
Nov 22, 2023
@dreacot |
the issue says the title should have the slide effect |
|
trying to start mixing causes a crash |
|
when mixer is enabled the asset slider height doesn't take full width on my macbook 
|
|
sliding anywhere on the page triggers the asset slider Screencast.from.2023-11-24.13.43.35.webm |
Closed
…n slider, update segmented for transaction tab
JustinBeBoy
changed the title
ukane-philemon
requested changes
Dec 1, 2023
This is the slide's rotation effect, but I'll fix it |
ukane-philemon
previously requested changes
Dec 2, 2023
There was a problem hiding this comment.
Noticed a page navigation mishap after navigating from the mixer page and also a log message that was supposedly fixed in #240.
Navigation issue:
Screen.Recording.2023-12-02.at.11.00.27.AM.mov
Duplicate mixer log error:
2023-12-02 10:59:53.670 [ERR] UI: Error adding account mixer notification listener: listener_already_exist
2023-12-02 11:00:30.595 [ERR] UI: Error adding account mixer notification listener: listener_already_exist
2023-12-02 11:00:52.064 [ERR] UI: Error adding account mixer notification listener: listener_already_exist
That's not within the scope of this PR, please make an issue of it |
Yes, you are correct. I also experienced the issue on master. |
|
swiping left goes to the other page, if there's nothing to swipe to then the sliding shouldn't do anything Screencast.from.2023-12-04.12.38.06.webm |
done |
Yup, but I get this panic:
```
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x100e57feb]
goroutine 60 [running]: |
I can't reproduce it, but I guessed it not relate to this PR, Did you test it on master? |
Darn, just did and it's on master. |
dreacot
reviewed
Dec 5, 2023
|
this was not resolved #261 (comment) |
dreacot
reviewed
Dec 6, 2023
dreacot
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #161
closes #261
This PR:
screenshot