Actually try all ciphersuites until one works

cryspen · Nov 15, 2023 · 59b87c8 · 59b87c8
1 parent b6129dd
commit 59b87c8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/simple_https_client/src/lib.rs b/simple_https_client/src/lib.rs
@@ -127,17 +127,17 @@ const SHA384_Aes256Gcm_EcdsaSecp256r1Sha256_P256: Algorithms = Algorithms(
 pub fn ciphersuites() -> Vec<Algorithms> {
     vec![
         SHA256_Chacha20Poly1305_RsaPssRsaSha256_X25519,
-        //SHA256_Chacha20Poly1305_EcdsaSecp256r1Sha256_X25519,
-        //SHA256_Chacha20Poly1305_EcdsaSecp256r1Sha256_P256,
-        //SHA256_Chacha20Poly1305_RsaPssRsaSha256_P256,
-        // SHA256_Aes128Gcm_EcdsaSecp256r1Sha256_P256,
-        // SHA256_Aes128Gcm_EcdsaSecp256r1Sha256_X25519,
-        // SHA256_Aes128Gcm_RsaPssRsaSha256_P256,
-        // SHA256_Aes128Gcm_RsaPssRsaSha256_X25519,
-        // SHA384_Aes256Gcm_EcdsaSecp256r1Sha256_P256,
-        // SHA384_Aes256Gcm_EcdsaSecp256r1Sha256_X25519,
-        // SHA384_Aes256Gcm_RsaPssRsaSha256_P256,
-        // SHA384_Aes256Gcm_RsaPssRsaSha256_X25519,
+        SHA256_Chacha20Poly1305_EcdsaSecp256r1Sha256_X25519,
+        SHA256_Chacha20Poly1305_EcdsaSecp256r1Sha256_P256,
+        SHA256_Chacha20Poly1305_RsaPssRsaSha256_P256,
+        SHA256_Aes128Gcm_EcdsaSecp256r1Sha256_P256,
+        SHA256_Aes128Gcm_EcdsaSecp256r1Sha256_X25519,
+        SHA256_Aes128Gcm_RsaPssRsaSha256_P256,
+        SHA256_Aes128Gcm_RsaPssRsaSha256_X25519,
+        SHA384_Aes256Gcm_EcdsaSecp256r1Sha256_P256,
+        SHA384_Aes256Gcm_EcdsaSecp256r1Sha256_X25519,
+        SHA384_Aes256Gcm_RsaPssRsaSha256_P256,
+        SHA384_Aes256Gcm_RsaPssRsaSha256_X25519,
     ]
 }
 

diff --git a/simple_https_client/src/tls13client.rs b/simple_https_client/src/tls13client.rs
@@ -48,9 +48,8 @@ fn main() -> anyhow::Result<()> {
             Ok((_, _, response_prefix)) => response_prefix,
             Err(e) => {
                 // We ignore all errors here for now and keep trying.
-                eprintln!("tls13connet failed with {}", e);
-                break; // TODO FIX
-                       //continue;
+                eprintln!("tls13connect failed with {}", e);
+                continue;
             }
         };
         break;