Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend benchmarks #134

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Extend benchmarks #134

merged 4 commits into from
Jan 16, 2025

Conversation

jschneider-bensch
Copy link
Contributor

This PR extends performance benchmarking of the client to the PQ ciphersuites and adds a rough stack-painting based measurement of the Client's stack usage.

@jschneider-bensch jschneider-bensch requested a review from a team as a code owner January 16, 2025 10:31
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

@franziskuskiefer
Copy link
Member

CI doesn't seem happy with the stack bench though.

@jschneider-bensch
Copy link
Contributor Author

Ah, yes, psm does not fully support Windows. Okay to disable that benchmark for Windows?

@franziskuskiefer
Copy link
Member

Okay to disable that benchmark for Windows?

yes!

@jschneider-bensch jschneider-bensch merged commit 8e30564 into main Jan 16, 2025
10 checks passed
@jschneider-bensch jschneider-bensch deleted the jonas/measurements branch January 16, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants