Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonas/extend bogo coverage #68

Merged
merged 10 commits into from
Nov 14, 2023

Conversation

jallmann
Copy link
Contributor

This PR addresses the BoGo test integration described in issue #30 .

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Automation

Motivation and Context

We want to extend the number of passing testcases from the boringssl BoGo test suite.
This PR contributes to this goal by categorizing testcases, annotating their failure reasons, and fixing some of them through improved error mapping.

Changes

  • The config.json fiel for the bogo test suite is cleaned up and restructured to facilitate further work
  • A number of testcases is recategorized and/or annotated with current failure reasons
  • A number if testcases is removed from the list after fixing their failure reasons, mostly by fixing/enhancing the error mapping
  • Some more shim command line arguments are added to its ignore list

Checklist

  • I have linked an issue to this PR
  • I have described the changes
  • I have read and understood the code of conduct, contribution guidelines, and contributor license agreement
  • I have added tests for all changes
  • I have tested that all tests pass locally and all checks pass
  • I have updated documentation if necessary

@jallmann jallmann requested a review from a team as a code owner November 13, 2023 16:09
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm

@franziskuskiefer franziskuskiefer merged commit 0366520 into cryspen:main Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants