Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake standalone build #284

Merged
merged 2 commits into from
Nov 30, 2022
Merged

cmake standalone build #284

merged 2 commits into from
Nov 30, 2022

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Nov 30, 2022 •
edited
Loading

Fix CMake standalone builds and add an example for how to use hacl packages in a cmake project.
The way the includes work isn't great.
Follow ups

  • Let's make this easier to use (include paths)
  • Update the example
  • Add the example to the book

For reference: votingworks/electionguard-kotlin-multiplatform#200

@franziskuskiefer franziskuskiefer requested a review from a team as a code owner November 30, 2022 15:45
@cla-bot cla-bot bot added the cla-signed label Nov 30, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3584836974

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.985%
Totals Coverage Status
Change from base Build 3564982264: 0.0%
Covered Lines: 33230
Relevant Lines: 61554
💛 - Coveralls

duesee
duesee approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and works on my Ubuntu machine, too).

@franziskuskiefer franziskuskiefer mentioned this pull request Nov 30, 2022
Closed
@franziskuskiefer franziskuskiefer enabled auto-merge (rebase) November 30, 2022 16:12
@franziskuskiefer franziskuskiefer merged commit 2526e14 into main Nov 30, 2022
@franziskuskiefer franziskuskiefer deleted the franziskus/cmake-standalone-build branch November 30, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franziskuskiefer @coveralls @duesee