Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better integrate cmake example #311

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Better integrate cmake example #311

merged 3 commits into from
Dec 16, 2022

Conversation

franziskuskiefer
Copy link
Member

@franziskuskiefer franziskuskiefer commented Dec 14, 2022 •
edited
Loading

  • Describe how to use HACL in a CMake project in the book.
  • Run the cmake example on CI

No windows in CI for now (it's failing and needs debugging).

Fixes #268

@franziskuskiefer
Better integrate cmake example
c4f89b5 
- Describe how to use HACL in a CMake project in the book.
- Run the cmake example on CI
@cla-bot cla-bot bot added the cla-signed label Dec 14, 2022
@coveralls
Copy link

coveralls commented Dec 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3702312332

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.966%
Totals Coverage Status
Change from base Build 3697687686: 0.0%
Covered Lines: 33754
Relevant Lines: 60312
💛 - Coveralls

@franziskuskiefer franziskuskiefer marked this pull request as ready for review December 15, 2022 08:29
@franziskuskiefer franziskuskiefer requested a review from a team as a code owner December 15, 2022 08:29
duesee
duesee approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@duesee
Copy link
Contributor

duesee commented Dec 15, 2022

Could you file an issue about the Windows CI failure?

@franziskuskiefer franziskuskiefer mentioned this pull request Dec 16, 2022
Open
@franziskuskiefer franziskuskiefer merged commit c17f2eb into main Dec 16, 2022
@franziskuskiefer franziskuskiefer deleted the franziskus/cmake-example-docs branch December 16, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake support
3 participants
@franziskuskiefer @coveralls @duesee