Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all variants of kyber to hacl-packages, with compilation and all #463

Merged
merged 25 commits into from
May 15, 2024

Conversation

msprotz
Copy link
Collaborator

@msprotz msprotz commented May 7, 2024

This PR contains a smorgasbord of improvements, namely in support of compiling all Kyber variants.

  • Refresh the code with Libcrux optimize decap libcrux#257
  • Fixup a variety of things in config/default_config_msvc.{cmake,h}
  • Same deal with the non-msvc configs to support multiple files
  • Refresh kyber code with latest Eurydice improvements to generate for-loops when applicable
  • Refresh bundled copy of google benchmark owing to an issue that breaks the clang build on windows
  • Silence more MSVC compiler warnings with updated version of fstar_uint128_msvc.h
  • Performance boost (16%): do not constantly query evercrypt autoconfig init on a hot-path
  • Improve the glue all over to support 512 and 1024 variants
  • A script to eventually provide a standalone package of kyber for consumption downstream. In the long run, I would like this to be a CI artifact completely reproducible that people can download off of github.

@msprotz msprotz requested a review from a team as a code owner May 7, 2024 00:37
@cla-bot cla-bot bot added the cla-signed label May 7, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8977766250

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.064%

Totals Coverage Status
Change from base Build 8723980584: 0.0%
Covered Lines: 38622
Relevant Lines: 65390

💛 - Coveralls

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's get it in.

@franziskuskiefer franziskuskiefer disabled auto-merge May 15, 2024 13:23
@franziskuskiefer franziskuskiefer merged commit aee06b1 into dev May 15, 2024
38 checks passed
@franziskuskiefer franziskuskiefer deleted the protz_all_kyber_variants branch May 15, 2024 13:23
@franziskuskiefer
Copy link
Member

It looks like #464 was the same branch and got closed because this got merged 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants