Add more info to ImplExprAtom::Builtin
#1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
improve-implexpr-builtin
branch
from
46271b2 to
c44a062
Compare
Nadrieril
force-pushed
the
improve-implexpr-builtin
branch
from
c44a062 to
0abb723
Compare
W95Psp
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
LGTM, thanks! :)
Let's just wait for https://github.com/cryspen/libcrux/actions/runs/12868874954/job/35876441593 to be green! (maybe it will fail, because of some inlined impl IDs)
|
It's green, we can merge (assuming the Charon failure is expected!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some info to
ImplExprthat I need to handle associated types properly.