Move more share permission checks to usershareprovider #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to make sure the requesting user has the AddGrant permission on the desired resource before we create a share.
We need to make sure the requesting user is either the owner/creator of the share or has the RemoveGrant permission on the desired resource before deleting a share.
We need to make sure the requesting user is either the owner/creator of the share or has the UpdateGrant permission on the desired resource before deleting a share.
rhafer
force-pushed
the
update-share-permission-check
branch
from
1495a72 to
0431ec9
Compare
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 19, 2023
rhafer
added a commit
to rhafer/ocis
that referenced
this pull request
Dec 19, 2023
kobergj
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user share provider now checks if the user has sufficient permissions to add, delete or update a share.