Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no need to unmark postprocessing when it was not started #4476

Merged
merged 1 commit into from
Jan 24, 2024
Merged

no need to unmark postprocessing when it was not started #4476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/no-need-to-unmark-postprocessing-when-it-was-not-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix: no need to unmark postprocessing when it was not started

https://github.com/cs3org/reva/pull/4476
2 changes: 1 addition & 1 deletion pkg/storage/utils/decomposedfs/upload/session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ func (s *OcisSession) MTime() time.Time {
return t
}

// IsProcessing returns true if all bytes have been received. The node then has entered postprocessing state.
// IsProcessing returns true if all bytes have been received. The session then has entered postprocessing state.
func (s *OcisSession) IsProcessing() bool {
return s.info.Size == s.info.Offset
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/storage/utils/decomposedfs/upload/upload.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ func (session *OcisSession) FinishUpload(ctx context.Context) error {

n, err := session.store.CreateNodeForUpload(session, attrs)
if err != nil {
session.store.Cleanup(ctx, session, true, false, true)
session.store.Cleanup(ctx, session, true, false, false)
return err
}

Expand Down
Loading