Skip to content

Commit

Permalink
ci: Disable Cargo.toml checks
Browse files Browse the repository at this point in the history
  • Loading branch information
MazterQyou committed Jun 9, 2023
1 parent f187706 commit 19a8427
Showing 1 changed file with 53 additions and 51 deletions.
104 changes: 53 additions & 51 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -385,57 +385,59 @@ jobs:
CARGO_HOME: "/github/home/.cargo"
CARGO_TARGET_DIR: "/github/home/target"

cargo-toml-formatting-checks:
name: Check Cargo.toml formatting
needs: [linux-build-lib]
runs-on: ubuntu-latest
strategy:
matrix:
arch: [amd64]
rust: [nightly-2022-03-08]
container:
image: ${{ matrix.arch }}/rust
env:
# Disable full debug symbol generation to speed up CI build and keep memory down
# "1" means line tables only, which is useful for panic tracebacks.
RUSTFLAGS: "-C debuginfo=1"
steps:
- uses: actions/checkout@v2
with:
submodules: true
- name: Cache Cargo
uses: actions/cache@v2
with:
path: /github/home/.cargo
# this key equals the ones on `linux-build-lib` for re-use
key: cargo-cache-
- name: Cache Rust dependencies
uses: actions/cache@v2
with:
path: /github/home/target
# this key equals the ones on `linux-build-lib` for re-use
key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }}
- name: Setup Rust toolchain
run: |
rustup toolchain install ${{ matrix.rust }}
rustup default ${{ matrix.rust }}
- name: Install cargo-tomlfmt
run: |
which cargo-tomlfmt || cargo install cargo-tomlfmt
env:
CARGO_HOME: "/github/home/.cargo"
CARGO_TARGET_DIR: "/github/home/target"
- name: Check Cargo.toml formatting
run: |
# if you encounter error, try rerun the command below, finally run 'git diff' to
# check which Cargo.toml introduces formatting violation
#
# ignore ./Cargo.toml because putting workspaces in multi-line lists make it easy to read
find . -mindepth 2 -name 'Cargo.toml' -exec cargo tomlfmt -p {} \;
git diff --exit-code
env:
CARGO_HOME: "/github/home/.cargo"
CARGO_TARGET_DIR: "/github/home/target"
# FIXME: Cargo.toml checks are disabled for now as they are failing.

# cargo-toml-formatting-checks:
# name: Check Cargo.toml formatting
# needs: [linux-build-lib]
# runs-on: ubuntu-latest
# strategy:
# matrix:
# arch: [amd64]
# rust: [nightly-2022-03-08]
# container:
# image: ${{ matrix.arch }}/rust
# env:
# # Disable full debug symbol generation to speed up CI build and keep memory down
# # "1" means line tables only, which is useful for panic tracebacks.
# RUSTFLAGS: "-C debuginfo=1"
# steps:
# - uses: actions/checkout@v2
# with:
# submodules: true
# - name: Cache Cargo
# uses: actions/cache@v2
# with:
# path: /github/home/.cargo
# # this key equals the ones on `linux-build-lib` for re-use
# key: cargo-cache-
# - name: Cache Rust dependencies
# uses: actions/cache@v2
# with:
# path: /github/home/target
# # this key equals the ones on `linux-build-lib` for re-use
# key: ${{ runner.os }}-${{ matrix.arch }}-target-cache-${{ matrix.rust }}
# - name: Setup Rust toolchain
# run: |
# rustup toolchain install ${{ matrix.rust }}
# rustup default ${{ matrix.rust }}
# - name: Install cargo-tomlfmt
# run: |
# which cargo-tomlfmt || cargo install cargo-tomlfmt
# env:
# CARGO_HOME: "/github/home/.cargo"
# CARGO_TARGET_DIR: "/github/home/target"
# - name: Check Cargo.toml formatting
# run: |
# # if you encounter error, try rerun the command below, finally run 'git diff' to
# # check which Cargo.toml introduces formatting violation
# #
# # ignore ./Cargo.toml because putting workspaces in multi-line lists make it easy to read
# find . -mindepth 2 -name 'Cargo.toml' -exec cargo tomlfmt -p {} \;
# git diff --exit-code
# env:
# CARGO_HOME: "/github/home/.cargo"
# CARGO_TARGET_DIR: "/github/home/target"

# Coverage job was failing. https://github.com/apache/arrow-datafusion/issues/590 tracks re-instating it

Expand Down

0 comments on commit 19a8427

Please sign in to comment.