Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

iPhone6 plus fixes #121

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

twobitfool
Copy link

Fixes for #118, #119, and #120.

@cubiq
Copy link
Owner

cubiq commented Oct 8, 2014

we don't know how ios9 and 10 will work, now it works on the emulator but tomorrow who knows. What happens when OSX goes to 11? or when iOS to 10?

I believe we should better detect the simulator.

@twobitfool
Copy link
Author

Regardless of #120, I think it might be good idea to include the extra CSS rules.

If the buttons don't move in iOS v9 or v10, then everything will "just keep working", and we save everyone the trouble of patching their addtohomescreen.css to get the same behavior.

Fixing the simulator is just a nice side-effect of supporting future versions of iOS ;)

@cubiq
Copy link
Owner

cubiq commented Oct 8, 2014

I kinda agree but to date, all iOS versions needed a CSS update.

@twobitfool
Copy link
Author

Another approach might be to have some logic in the js file to add a class like ios-8-plus. Then everything works until Apple eventually moves the buttons -- and then we add a new rule ios-13-plus to override the position moving forward.

@alexonbalangue
Copy link

I tested on my iPhone 6 iOS 9.x (lastest) it work well done
https://www.alexonbalangue.me/project/developper/module-addhome-ios-android-joomla.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants