-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.3.2 #3
base: master
Are you sure you want to change the base?
0.3.2 #3
Conversation
RobCombs
commented
Sep 19, 2013
- Added documentation for installation
- Added support for handling and displaying foreign keys
- Added unit test support using tox
- Made display more appealing
- Added full serialization of inherited fields
- Fixed bugs
…rialized fullhistory object. Also add support to display many to many fields in the revision history.
…jango 1.1 and 1.4
…ially supported and require hardcoded download urls.
I can confirm that I'm using this code in an internal Django 1.5.4 app and it seems to work perfectly, and fixes the simplejson errors introduced by using fullhistory 0.3.1 with django 1.5+. |
We also use version 0.3.2 of django-fullhistory in our production environment that has heavy traffic. Here are a few screenshots: |
It's been five months. Can we please either get a response on this PR, or have maintainership of the PyPI package transferred to us? |
Hi, We will look to merge this pull request in the coming week. Sorry for the delay! |
@RobCombs hey if you happen to get a chance, could you take a peek at the merge conflicts and see if we can finally get this merged? I'm a bit confused, it seems like someone pushed to master recently... if you don't have the time or desire, I can try to get this done... |
I took a look at merging this and the only issue i am not clear on is the change on fullhistory/admin.py where you replace the context variable with a hardcoded version. This eliminates the ability for extra_context to be passed in. I am not sure of the implication of this in our code, but I imagine the most compatible approach would be to have it be both your admin_name change, as well as the extra context. e.g. context = dict(self.get_context(), **(extra_context if extra_context else {})) I am going to take a look at how this impacts our systems, but would this work for you application? Thanks, |