Skip to content

Commit

Permalink
Add TODO to handle not only column ref expression
Browse files Browse the repository at this point in the history
  • Loading branch information
dentiny committed Jan 19, 2025
1 parent 491af18 commit 0d78885
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/core/functions/table/match.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,11 @@ PGQMatchFunction::CheckColumnBinding(const CreatePropertyGraphInfo &pg_table,
GetFullyQualifiedColFromPg(pg_table, alias_to_vertex_and_edge_tables);

for (auto &expression : ref.column_list) {
// TODO(hjiang): `ColumnRefExpression` alone is not enough, we could have
// more complicated expression.
//
// See issue for reference:
// https://github.com/cwida/duckpgq-extension/issues/198
auto *column_ref = dynamic_cast<ColumnRefExpression *>(expression.get());
if (column_ref == nullptr) {
continue;
Expand Down

0 comments on commit 0d78885

Please sign in to comment.