-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use sharrows for bicycle=designated streets #542
base: master
Are you sure you want to change the base?
Conversation
[oneway='-1'] { designated/marker-file: url(symbols/oneway-reverse.svg); } | ||
[zoom=15] { | ||
designated/marker-transform: "scale(0.75)"; | ||
designated/marker-spacing: 40; | ||
} | ||
} | ||
[bicycle='designated'][oneway = 'yes'][oneway_bicycle = 'no'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a duplicate with https://github.com/cyclosm/cyclosm-cartocss-style/pull/542/files#diff-7f4b9a4751a0a11cd2e9b3a1919623c344185a0cbce66d3534b4ea26066fcffaR473-R485. But to be double checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of what ?
This part is for designated on a road cyclable in both direction.
Here we need a both direction sharrow like : <<>>
I like the idea of using sharows, the icon is good. |
Updated the marker spacing. I quite like how this looks: I don't worry too much about the sharrow sign, it really makes me think in pictures like this one https://www.francebleu.fr/infos/transports/strasbourg-inaugure-la-premiere-velorue-de-france-1494593960 |
designated/marker-fill: @cycle-fill; | ||
designated/marker-file: url(symbols/oneway.svg); | ||
designated/marker-file: url(symbols/nounproject/sharrows.svg); | ||
[oneway='-1'] { designated/marker-file: url(symbols/oneway-reverse.svg); } | ||
[zoom=15] { | ||
designated/marker-transform: "scale(0.75)"; | ||
designated/marker-spacing: 40; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove it, change to 60 ? like others
designated/marker-fill: @cycle-fill; | ||
designated/marker-file: url(symbols/oneway.svg); | ||
designated/marker-file: url(symbols/nounproject/sharrows.svg); | ||
[oneway='-1'] { designated/marker-file: url(symbols/oneway-reverse.svg); } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to change this svg.
[oneway='-1'] { designated/marker-file: url(symbols/oneway-reverse.svg); } | ||
[zoom=15] { | ||
designated/marker-transform: "scale(0.75)"; | ||
designated/marker-spacing: 40; | ||
} | ||
} | ||
[bicycle='designated'][oneway = 'yes'][oneway_bicycle = 'no'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate of what ?
This part is for designated on a road cyclable in both direction.
Here we need a both direction sharrow like : <<>>
It'd be great to have this one on the next version. Here an example with both oneway/twoway designated road (side way of av Corentin Carriou) |
Sure, I'll have a look and finish it! |
See Rue de Rivoli (https://www.openstreetmap.org/#map=20/48.85543/2.36042&layers=Y):
Fix #389