Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added debug statements for key presses #413

Merged
merged 2 commits into from
Feb 28, 2018
Merged

Added debug statements for key presses #413

merged 2 commits into from
Feb 28, 2018

Conversation

neilmunday
Copy link
Contributor

Added debug statements for key presses for issue #324.

cztomczak
cztomczak requested changes Feb 25, 2018
View reviewed changes
Copy link
Owner

@cztomczak cztomczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in the debug message that these are char and keyup events for SDL_TEXTINPUT. Would be useful also to add logging for SDL_KEYUP and SDL_KEYDOWN. And that's all events in regards to key handling? Thanks.

@neilmunday
Copy link
Contributor Author

Done.

cztomczak
cztomczak approved these changes Feb 28, 2018
View reviewed changes
Copy link
Owner

@cztomczak cztomczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cztomczak cztomczak merged commit ae3aa72 into cztomczak:master Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cztomczak cztomczak cztomczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilmunday @cztomczak