Improve some logging if we fail to remove working status

daneren2005 · Oct 28, 2021 · b79a14a · b79a14a
1 parent 30857ad
commit b79a14a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/Resque/Job.php b/lib/Resque/Job.php
@@ -206,7 +206,10 @@ public function perform()
 				$instance->tearDown();
 			}
 
-			Resque::redis()->lrem('working:' . $this->queue, 0, $this->payload['id']);
+			$removed = Resque::redis()->lrem('working:' . $this->queue, 0, $this->payload['id']);
+			if($removed <= 0) {
+				$this->worker->logger->log(Psr\Log\LogLevel::EMERGENCY, $this->payload['id'] . ' was not removed from working:' . $this->queue);
+			}
 			Resque_Event::trigger('afterPerform', $this);
 		}
 		// beforePerform/setUp have said don't perform this job. Return.

diff --git a/lib/Resque/Worker.php b/lib/Resque/Worker.php
@@ -261,7 +261,7 @@ public function work($interval = Resque::DEFAULT_INTERVAL, $blocking = false)
 					} else {
 						if (in_array($job->getStatus(), array(Resque_Job_Status::STATUS_RUNNING))) {
 							$job->updateStatus(Resque_Job_Status::STATUS_COMPLETE);
-							$this->logger->log(Psr\Log\LogLevel::INFO, 'done' . $job);
+							$this->logger->log(Psr\Log\LogLevel::INFO, 'Updating job status as done for ' . $job);
 						}
 					}
 				}
@@ -271,7 +271,7 @@ public function work($interval = Resque::DEFAULT_INTERVAL, $blocking = false)
 			$this->child = null;
 			$this->doneWorking();
 
-			$this->logger->log(Psr\Log\LogLevel::INFO, 'Done workering on child {child} for {worker}', Array(
+			$this->logger->log(Psr\Log\LogLevel::INFO, 'Done working on child {child} for {worker}', Array(
 				'child' => $child,
 				'worker' => $this
 			));