Round Animate.to target #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes never ending lerping when to is not an integer thus never passing the Math.round check to determine animation completion. See https://github.com/studio-freight/lenis/issues/168
|
Someone is attempting to deploy a commit to the Studio Freight Team on Vercel. A member of the Team first needs to authorize it. |
|
Fixed by studio-freight/lenis@96989b9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix never ending lerping when
tois not an integer thus never passing theMath.round(this.value) === this.tocheck to determine animation completion.Fix this issue https://github.com/studio-freight/lenis/issues/168
This approach rounds the
tovalue directly when its set from thefromTomethod as it should be more efficient than rounding it at everyadvancecall to compare values.