Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo #6322

Merged
merged 1 commit into from
Jan 26, 2025
Merged

typo #6322

merged 1 commit into from
Jan 26, 2025

Conversation

Tox46
Copy link
Contributor

@Tox46 Tox46 commented Jan 11, 2025

Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

Fixes


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
  • This PR doesn't contain automatically generated corrections or text (Grammarly, LLMs, and similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn't use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.
Contribution guidelines:
  • See our contributor guide for general expectations for PRs.
  • Larger or significant changes should be discussed in an issue before creating a PR.
  • Code changes should generally follow the Dart style guide and use dart format.
  • Updates to code excerpts indicated by <?code-excerpt need to be updated in their source .dart file as well.

Copy link

google-cla bot commented Jan 11, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR!

However, before we can review (or land) your PR, you'll need to sign the CLA as outlined in the earlier bot comment. If you have any issues doing so though, please let us know. Thanks again!

Copy link
Contributor

@MaryaBelanger MaryaBelanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Tox46!

@MaryaBelanger
Copy link
Contributor

@Tox46 Just checking again if you saw the comment above. You'll have to sign the CLA for us to merge this. We'll give you another week or so but then have to close it and fix the typo ourselves. Thanks!

@Tox46
Copy link
Contributor Author

Tox46 commented Jan 24, 2025

This really shouldn't have taken this long and i'm sorry for that, i was investigating on a related (?) issue, as it seems to me that the flag in question has no effect whether with no or not, but i guess it does not belong to this repo. i've signed everything, tell me if i need to do anything else.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Tox46 for fixing this!

And sorry about the extra work relating to the CLA.

@parlough parlough merged commit e496277 into dart-lang:main Jan 26, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants