Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase delay between submitting and voting on proposals #591

Open
wants to merge 2 commits into
base: v1.0-dev
Choose a base branch
from

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Oct 19, 2023

Issue being fixed or feature implemented

Proposals were successfully created but gobject list was empty resulting in gobject vote-many being skipped. Manually checking the proposal count and running the role twice resulted in successful votes, so I think we are just going too quickly here for the slowish P2P governance system.

What was done?

Increase block delay between steps and add 10 second wait just in case

How Has This Been Tested?

On devnet-ouzo

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.25.0 milestone Oct 19, 2023
@strophy strophy requested a review from ktechmidas October 19, 2023 01:10
@shumkov shumkov changed the base branch from v0.25-dev to v1.0-dev January 13, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant