Skip to content

Commit

Permalink
fix: use correct interruption condition in StartCachePopulatorThread (
Browse files Browse the repository at this point in the history
#5732)

## Issue being fixed or feature implemented
#4788 (comment)

noticed while working on #5731

## What was done?

## How Has This Been Tested?
run a node, check logs - there is a meaningful time span between `start`
and `done` now and not just zeros all the time.

## Breaking Changes

## Checklist:
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
  • Loading branch information
UdjinM6 authored Nov 27, 2023
1 parent e6d6e8a commit 6c57cc2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/llmq/quorums.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@ void CQuorumManager::StartCachePopulatorThread(const CQuorumCPtr pQuorum) const
// when then later some other thread tries to get keys, it will be much faster
workerPool.push([pQuorum, t, this](int threadId) {
for (const auto i : irange::range(pQuorum->members.size())) {
if (!quorumThreadInterrupt) {
if (quorumThreadInterrupt) {
break;
}
if (pQuorum->qc->validMembers[i]) {
Expand Down

0 comments on commit 6c57cc2

Please sign in to comment.