fix: pass GITHUB_REPOSITORY into Dockerfile.GitHubActions.Release
#5724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strophy
approved these changes
Nov 21, 2023
|
TSAN unit test is failing here? |
|
that's an interesting failure but a completely unrelated one imo |
Is it an actual issue or just random? |
5 tasks
#5726 should help I think |
PastaPastaPasta
approved these changes
Nov 24, 2023
5 tasks
PastaPastaPasta
pushed a commit
that referenced
this pull request
Dec 4, 2023
…d attempt) (#5735) ## Issue being fixed or feature implemented I was probably using `GITHUB_REPOSITORY` incorrectly, let's try it this way #5724 follow-up ## What was done? ## How Has This Been Tested? n/a ## Breaking Changes n/a ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Should hopefully fix https://github.com/dashpay/dash-dev-branches/actions/runs/6939402277/job/18876687119
#5716 follow-up
What was done?
$GITHUB_REPOSITORYis not available inside docker, pass it insideHow Has This Been Tested?
Breaking Changes
n/a
Checklist: