Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace goacc with go test for coverage checks #27

Merged
merged 9 commits into from
Dec 18, 2024

Conversation

lklimek
Copy link

@lklimek lklimek commented Dec 18, 2024

Since go 1.20, go test produces valid coverage reports for our use case.

Replaced go-acc with go test for coverage tests.

@lklimek lklimek added this to the v0.26 milestone Dec 18, 2024
@coveralls
Copy link

coveralls commented Dec 18, 2024

Pull Request Test Coverage Report for Build 12391694589

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on ci/fix-coverage-tests at 48.925%

Totals Coverage Status
Change from base Build 12391353757: 48.9%
Covered Lines: 23617
Relevant Lines: 48272

💛 - Coveralls

@lklimek lklimek merged commit b388223 into deps/update-all Dec 18, 2024
3 checks passed
@lklimek lklimek deleted the ci/fix-coverage-tests branch December 18, 2024 11:09
lklimek added a commit that referenced this pull request Dec 18, 2024
…ons (#25)

* build: update all dependencies

* build: update gh actions

* test: fix  error msg

* build: update submodule deps

* test(btcec): update tests for new secp256k1

* test: replace goacc with go test for coverage checks (#27)

* build: replace goacc with go test for coverage

* fix

* chore: gha perm denied

* chore: try to fix perm denied

* Revert "chore: try to fix perm denied"

This reverts commit 97be971.

* chore: coverage file list fix

* chore: remove /v2 which shall not be needed anymore

* chore: run tests on release created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants