Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve button layout #200

Merged
merged 5 commits into from
Jul 20, 2021
Merged

Conversation

ian-r-rose
Copy link
Collaborator

@ian-r-rose ian-r-rose commented Jul 20, 2021

Some stylistic updates to the dashboard launcher buttons:

  1. Remove default buttons, instead show a "Dashboard not connected" message if there is no valid dashboard (fixes Remove default dashboard plots #198).
  2. Alphabetize the buttons so they are in a more predictable location (fixes Sort order of plots #199 )
  3. Changes the layout so buttons are one-per-line (I had changed it in prehistory to layout row-wise with overflow so we could fit more buttons in, but I think that made things too busy, and also made it tougher to find buttons)

Screenshots:
image

image

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! Nice work @ian-r-rose.

I wonder if we should provide some kind of tip to the user when the dashboard isn't connected on how to connect one.

@ian-r-rose
Copy link
Collaborator Author

ian-r-rose commented Jul 20, 2021 via email

@ian-r-rose
Copy link
Collaborator Author

Now with a more informative message:
image

@jacobtomlinson
Copy link
Member

Awesome!

@jacobtomlinson jacobtomlinson merged commit f614145 into dask:main Jul 20, 2021
@ian-r-rose
Copy link
Collaborator Author

Thanks for the review @jacobtomlinson!

@jrbourbeau
Copy link
Member

This looks great!

@GenevieveBuckley
Copy link
Contributor

Thanks for doing this @ian-r-rose

I've been using jupyter lab instead of just the notebook more and more these days, and was just coming over here to whinge about exactly this! It's going to be a lot less frustrating now

@ian-r-rose
Copy link
Collaborator Author

Published in dask-labextension==5.1.0

@mrocklin
Copy link
Member

mrocklin commented Jul 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort order of plots Remove default dashboard plots
5 participants