Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): fix lost data in custom exchange #16930

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

fix(query): fix lost data in custom exchange #16930

wants to merge 7 commits into from

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Nov 25, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): fix lost data in custom exchange

Found in #16878

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 25, 2024
@zhang2014 zhang2014 enabled auto-merge November 25, 2024 03:57
@xudong963
Copy link
Member

Not sure if will help the issue: #16941 @zhang2014

@zhang2014
Copy link
Member Author

Not sure if will help the issue: #16941 @zhang2014

No, there is no logical dependency on custom mode code.

@zhang2014 zhang2014 marked this pull request as draft November 27, 2024 02:10
auto-merge was automatically disabled November 27, 2024 02:10

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forsaken628 forsaken628 forsaken628 approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhang2014 @xudong963 @forsaken628 @BohuTANG