Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(metrics): tune the histogram bucket for seconds/milliseconds #17197

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flaneur2020
Copy link
Member

@flaneur2020 flaneur2020 commented Jan 7, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

currently the bucket for time are at most half an hour, but when running complex queries, it's not impossible to run a query for 3 hours.

this pr adds 3 bucket for hour granurity buckets (up to 8 hours), and removes bucket for 0.01s & 20s to make it align at 16 elements.

Tests

  • No Test - small change on histogram buckets

Type of change

  • Other (please describe): metrics configurations

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 7, 2025
@flaneur2020 flaneur2020 marked this pull request as ready for review January 7, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants