Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick changes from the 6.5.0 branch #20

Open
wants to merge 6 commits into
base: databricks-bazel-7.4.1
Choose a base branch
from

Conversation

fbenkstein-db
Copy link
Collaborator

No description provided.

apattidb and others added 6 commits January 7, 2025 10:16
* [bre] Flag to control pools based on test sizes

* more docs
This options will have the server start in the user-specifed cgroup. This is useful when using the cgroup features in bazel and thus the server must be started in a user-writable cgroup.

Closes bazelbuild#21618.

PiperOrigin-RevId: 666305298
Change-Id: Ide3bb3f65bd11f4ecc11d6e843926a16ecb41f2f
We have an internal system which tacks an aspect onto all the builds it runs,
but no one really cares about the aspect's outputs, just that with the default
--show_result their normal results are suppressed. This lets us avoid that.

There are a few ways we could have implemented this, I decided to go with the
simplest - non-repeated flag with comma-separated values. Practically, we could
evolve this to allow multiple and do something like we do with --output_group
with adding/subtracting from the existing/default, but we can cross that bridge
when/if we get there.

PiperOrigin-RevId: 603229525
Change-Id: I8b1a387eeb7e67cceaf4f8e821bd29c12b136982
@fbenkstein-db fbenkstein-db requested a review from apattidb January 8, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants