feat: allow multiple documents in std.parseYaml
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya @lihaoyi-databricks 👋 Is there any chance I could please get a review on this one? ❤️ Thanks! |
He-Pin
reviewed
May 20, 2024
stephenamar-db
approved these changes
Dec 2, 2024
stephenamar-db
force-pushed
the
alexb/allow-multi-documents
branch
from
adf35f6 to
14e3bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya Team 👋
While trying to give
sjsonneta whirl, we noticed a few of ourstd.parseYamlcalls were failing if they included multi doc YAML. (deliminated by the old---).This PR allows the
yamlToJsonfunction to parse these files/YAML streams and return the appropriate JSON string.I'm a first time contributor to this repo, and furthermore it's my first time writing Scala.
Please do let me know if there's a better way to accomplish this, I'm more than happy to work through any of the feedback I receive!
Thanks!