Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Make "createConverterToAvro" function public static #220

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ovj
Copy link

@ovj ovj commented Mar 14, 2017

This will help createConverterToAvro being used outside of AvroOutputWriter.

@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #220 into master will decrease coverage by 0.43%.
The diff coverage is 96.07%.

@@            Coverage Diff             @@
##           master     #220      +/-   ##
==========================================
- Coverage    90.4%   89.96%   -0.44%     
==========================================
  Files           5        5              
  Lines         323      329       +6     
  Branches       49       52       +3     
==========================================
+ Hits          292      296       +4     
- Misses         31       33       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19f01a...fd7ea18. Read the comment docs.

@mnarrell
Copy link

Wouldn't it make sense to change the access modifiers on all these schema conversion functions? We have lots of AVRO encoded data that is not accessible via a filesystem path (stored in Redis/RDBMS/etc) that we'd love to transform into Dataframes and vice versa.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants