Add slither analysis to CI

.github/workflows/test.yml

@@ -36,3 +36,16 @@ jobs:
 
     - name: Lint
       run: make lint
+
+  slither:
+    name: Slither analysis
+    needs: contract-test
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+      - uses: crytic/[email protected]
+        with:
+          node-version: 20.13
+          slither-version: 0.10.1

Makefile

@@ -1,5 +1,6 @@
 SOLC_VERSION=0.8.20
 FORGE=forge
+SLITHER=slither
 TEST_UPGRADEABLE=false
 
 .PHONY: build
@@ -18,6 +19,10 @@ test:
 coverage:
 	@$(FORGE) coverage --ffi --use solc:$(SOLC_VERSION)
 
+.PHONY: slither
+slither:
+	@$(SLITHER) .
+
 .PHONY: fmt
 fmt:
 	@$(FORGE) fmt $(FORGE_FMT_OPTS) \

slither.config.json

@@ -0,0 +1,4 @@
+{
+  "detectors_to_run": "arbitrary-send-erc20,array-by-reference,incorrect-shift,name-reused,rtlo,suicidal,uninitialized-storage,arbitrary-send-erc20-permit,controlled-array-length,controlled-delegatecall,delegatecall-loop,msg-value-loop,reentrancy-eth,unchecked-transfer,weak-prng,domain-separator-collision,erc20-interface,erc721-interface,locked-ether,mapping-deletion,shadowing-abstract,tautology,write-after-write,boolean-cst,reentrancy-no-eth,reused-constructor,tx-origin,unchecked-lowlevel,unchecked-send,variable-scope,void-cst,events-access,events-maths,incorrect-unary,boolean-equal,deprecated-standards,erc20-indexed,function-init-state,pragma,reentrancy-unlimited-gas,immutable-states,var-read-using-this",
+  "filter_paths": "(test/|node_modules/|contracts/proto/)"
+}