Audit-202409 #24
Merged
Audit-202409 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jun Kimura <[email protected]>
LCP-4: Fix out-of-boundary access in `LCPUtils::readBytesUntil()` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
…stHeight` Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Fix S2 and S3 Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
S4: Add gap storage to `LCPClientBase` contract Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
Fix parallel test execution Signed-off-by: Jun Kimura <[email protected]>
Signed-off-by: Jun Kimura <[email protected]>
bluele
commented
Nov 20, 2024
| // repeat updateClient to check the state is not changed | ||
| message = createUpdateClientMessage(dataList[i].path); | ||
| // staticcall is expected to succeed because updateClient does not update the state if the message is already processed | ||
| (bool success, bytes memory ret) = address(lc).staticcall( |
There was a problem hiding this comment.
should check if success is true here.
Fixed at 86e5a24
Signed-off-by: Jun Kimura <[email protected]>
S8: fix to remove unused code Signed-off-by: Jun Kimura <[email protected]>
…d `clientState.allowed_advisory_ids` Signed-off-by: Jun Kimura <[email protected]>
S2-3: improve validations for `clientState.allowed_quote_statuses` and `clientState.allowed_advisory_ids` Signed-off-by: Jun Kimura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.