Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded the people section #41

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Expanded the people section #41

wants to merge 3 commits into from

Conversation

ajg54
Copy link

@ajg54 ajg54 commented Jan 29, 2024

Wanted to include the category of non-member and specify an explanatory example journey with dvp whilst avoiding making it sounds like a fixed process.

@ajg54 ajg54 self-assigned this Jan 29, 2024
@ajg54
Copy link
Author

ajg54 commented Jan 29, 2024

Hereby sharing an idea about updating the people page.

@DBCerigo
Copy link
Contributor

Nice oneeeeee 😸

I think the two parts would be good contributions. I think the implementation would benefit from being a bit more concise if pos ala https://github.com/datavaluepeople/dvp-defining-docs?tab=readme-ov-file#contributing-to-this-repo

I think the grammatical fix/change to the Members bit is good, but not so sure about removing the bit about becoming a partner, I think that's pretty important, to show that all members always have the possibility of being a partner.

I think best way to progress would be to break up the changes into different commits. This will make it easier to review and discuss and more likely and faster for it to get agreed and merged. Something like a commit for each of:

  • grammar fix
  • removing the bit about becoming partners
  • paragraph on freelances
  • paragraph on journey

@ajg54
Copy link
Author

ajg54 commented Jan 30, 2024

Thanks for taking a look. I recalled some discussion about whether there was an expectation that members should eventually become partners, which was why I thought to move that line from the definition to the journey. Perhaps the easiest way is to move it back (i.e. leave it as it was before), then there are just three changes: grammar fix, non-members and journey. At the same time I can trim the language a little.

@DBCerigo
Copy link
Contributor

recalled some discussion about whether there was an expectation that members should eventually become partners, which was why I thought to move that line from the definition to the journey.

Ye you totally right. That would be nice to capture also. I guess it is like "hope for partners, but no pressure and no frets if not".

@ajg54
Copy link
Author

ajg54 commented Feb 3, 2024

OK, the changes should now be split up over three commits. I have made the changes more modest both in terms of word count and difference from the original. In the end I didn't change the part about becoming a partner as I thought that hope already captured the intended vibe.

@ajg54 ajg54 marked this pull request as ready for review February 3, 2024 14:14
Copy link
Contributor

@DBCerigo DBCerigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea looking better and much easier to review now split up :)

Few comments, and also the formatting on line length isn't right on most of it. Having your editor auto-format text to do linebreaks up to a certain line-length is something well worth investing the time in!

Comment on lines -7 to +8
commitment. When they choose to make commitments they honour them. They can work on projects,
input to the direction and development of dvp, while slowly strengthening their
commitment. When they choose to make commitments they honour them. They can work on projects and
provide input to the direction and development of dvp, while slowly strengthening their
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

partner.

There is a further category of _non-member_ or _freelancer_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "There is a further category of people: non-member or similarly freelancer."

but has not become a member.

An example _journey_ for a newcomer could be performing a well-defined task for dvp,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: remove _ from journey.

before then engaging with dvp on a longer project.
They are subsequently invited to become a member,
and if the relationship continues to grow may eventually become a partner.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "to grow they may eventually".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants