-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded the people section #41
base: main
Are you sure you want to change the base?
Conversation
Hereby sharing an idea about updating the people page. |
Nice oneeeeee 😸 I think the two parts would be good contributions. I think the implementation would benefit from being a bit more concise if pos ala https://github.com/datavaluepeople/dvp-defining-docs?tab=readme-ov-file#contributing-to-this-repo I think the grammatical fix/change to the Members bit is good, but not so sure about removing the bit about becoming a partner, I think that's pretty important, to show that all members always have the possibility of being a partner. I think best way to progress would be to break up the changes into different commits. This will make it easier to review and discuss and more likely and faster for it to get agreed and merged. Something like a commit for each of:
|
Thanks for taking a look. I recalled some discussion about whether there was an expectation that members should eventually become partners, which was why I thought to move that line from the definition to the journey. Perhaps the easiest way is to move it back (i.e. leave it as it was before), then there are just three changes: grammar fix, non-members and journey. At the same time I can trim the language a little. |
Ye you totally right. That would be nice to capture also. I guess it is like "hope for partners, but no pressure and no frets if not". |
OK, the changes should now be split up over three commits. I have made the changes more modest both in terms of word count and difference from the original. In the end I didn't change the part about becoming a partner as I thought that hope already captured the intended vibe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea looking better and much easier to review now split up :)
Few comments, and also the formatting on line length isn't right on most of it. Having your editor auto-format text to do linebreaks up to a certain line-length is something well worth investing the time in!
commitment. When they choose to make commitments they honour them. They can work on projects, | ||
input to the direction and development of dvp, while slowly strengthening their | ||
commitment. When they choose to make commitments they honour them. They can work on projects and | ||
provide input to the direction and development of dvp, while slowly strengthening their |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
partner. | ||
|
||
There is a further category of _non-member_ or _freelancer_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: "There is a further category of people: non-member or similarly freelancer."
but has not become a member. | ||
|
||
An example _journey_ for a newcomer could be performing a well-defined task for dvp, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: remove _
from journey.
before then engaging with dvp on a longer project. | ||
They are subsequently invited to become a member, | ||
and if the relationship continues to grow may eventually become a partner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: "to grow they may eventually".
Wanted to include the category of non-member and specify an explanatory example journey with dvp whilst avoiding making it sounds like a fixed process.