-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New marketing/sales page #46
base: main
Are you sure you want to change the base?
Conversation
…members. We only need on such page, i.e. either a page called marketing or a page called sales but not both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start! I think using Sales and marketing
is a great way to be more precise and concise.
Apart from my comments, I think that a section:
## Where to start
For more resources and playbooks to get started on see the [`Sales and marketing` drive folder](https://drive.google.com/drive/u/0/folders/1cBEqjpyo35h50yy-uhFuzM7gY6LLSCaP)
Thanks for the feedback and good suggestions, which I have now tried to incorporate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks great.
Does need to be formated as the change in the line lengther makes it hard to read.
The other comment is not a required change.
…ength to 90 and line wrapping is now 'book style' rather than 'code style'.
…labelled that section.
I think all the points above have now been addressed and it should be ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yo, sorry it took me so long to review.
I think its really good.
Just this one sentence (that come from the other PR) that I think needs some work, given to me its like the crucial guiding principle. I included a suggested improvement in comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ye man nice!
@benjamincerigo just you to approve now FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajg54 do the honors!
Attempt to create a page for sales and marketing. Labelled as marketing because I think that is technically more what we are talking about than direct sales, but not precious about the naming. My natural instinct is to try to be precise then concise (opposite to the stated approach for these docs), but being a bit verbose at first (to make the intent clear) and then stripping it down to a slimmer and clear mutual understanding is perhaps not the worst way to go.
In a separate (draft) PR, there is a first draft of a similar page entitled sales. Only one of these two drafts needs to be finalized (potentially borrowing some content from the other), with the other being discarded.