Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the title when drag ends. #134

Closed
wants to merge 1 commit into from

Conversation

ankur2136
Copy link
Contributor

In current code, the last focussed bar label becomes the title when drag is finished.

In current code, the last focussed bar label becomes the title when drag is finished.
@dautovicharis
Copy link
Owner

dautovicharis commented Aug 3, 2024

Thanks for your contribution! We usually create PR to the develop branch, but I think this will be fine too :)

@dautovicharis
Copy link
Owner

dautovicharis commented Aug 3, 2024

@ankur2136 It would be great if you could create PR to the develop branch. If you need any help with that please let me know.

currently, we cannot run the sonar cloud, it seems it is not configured correctly for the contributor's PR.

Here is some info how we can do that:

origin/*  is your remote repo - under your github account
upstream/* is under mine github account.

Show remote branches
git branch -r

The results will be something like this:

origin/main 
upstream/develop
...
...

Clone upstream develop locally
git checkout -b “develop” upstream/develop

Push
git push origin develop

How to sync your origin/develop with upstream/develop:

git fetch upstream 
git checkout develop 
git merge upstream/develop
git push origin develop

Final steps

  • Create bugfix/ branches from your local develop branch
  • Create PR to the upstream/develop

@ankur2136 ankur2136 closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants