Skip to content

Commit

Permalink
Merge pull request #438 from db-ui/fix-icons-for-input
Browse files Browse the repository at this point in the history
fix(input): filled icons for inputstate
  • Loading branch information
annsch authored Feb 15, 2023
2 parents 55d27e6 + e1573c7 commit a791fe6
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/components/src/components/input/input.scss
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@

&::after,
&::before {
--icon-font-family: var(--db-base-icon-font-family);
--icon-font-family: var(--db-base-icon-font-family-filled);
--icon-font-size: var(--db-base-icon-font-size);
right: 0;
}
Expand Down Expand Up @@ -325,7 +325,9 @@

& ~ .icon-input-state,
& ~ .icon-input-state .db-icon {
@include icon(glyph(error), 20, "filled", "after", false);
// TODO fix this workaround after new icon implementation
--icon-glyph: "\e1123";
@include icon(glyph(error), 24, "outline", "after", true);
}
}

Expand Down
11 changes: 11 additions & 0 deletions showcases/react-showcase/src/components/input/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,17 @@ const variants: DefaultComponentVariants[] = [
/>
)
},
{
name: 'Invalid',
example: (
<DBInput
label={defaultLabelText}
minLength={5}
required={true}
description="minLength=5"
/>
)
},
{
name: 'Disabled',
example: (
Expand Down

0 comments on commit a791fe6

Please sign in to comment.