Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace DB icons with whitelabel open source icons #3653

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat: replace DB icons with whitelabel open source icons #3653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
030b822
feat: replace DB icons with whitelabel open source icons
nmerget Jan 8, 2025
78d59a2
Merge branch 'main' into feat-whitelabel-icons
nmerget Jan 8, 2025
4db6830
fix: linting issues
nmerget Jan 8, 2025
676c8c2
Update packages/components/src/styles/_button-components.scss
nmerget Jan 9, 2025
8e25a54
chore: update .gitignore
nmerget Jan 9, 2025
d55ea15
fix: linting issues
nmerget Jan 9, 2025
11b89ec
fix: linting issues
nmerget Jan 9, 2025
6702139
chore: update to icon-font-tools
nmerget Jan 9, 2025
d56a849
Merge remote-tracking branch 'origin/main' into feat-whitelabel-icons
nmerget Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .config/.jscpd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"packages/components/src/components/radio/radio.lite.tsx",
"packages/components/src/components/tag/tag.spec.tsx",
"packages/foundations/assets/icons/functional/fonts/**",
"packages/foundations/assets/icons/fonts/**",
"packages/foundations/src",
"showcases/**/results/**",
"showcases/angular-showcase/.angular/cache",
Expand Down
22 changes: 11 additions & 11 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,18 +46,18 @@ showcases/patternhub/public/iframe-resizer/*
**/recordings/

/__snapshots__/**/*-win32.png
/packages/foundations/assets/icons/functional/tmp/
/packages/foundations/assets/icons/functional/fonts/**/index.html
/packages/foundations/assets/icons/functional/fonts/**/index.css
/packages/foundations/assets/icons/functional/fonts/**/font-face.css
/packages/foundations/assets/icons/functional/fonts/**/info.json
/packages/foundations/scss/_normalize.scss

/packages/foundations/assets/icons/functional/fonts/**/*.eot
/packages/foundations/assets/icons/functional/fonts/**/*.svg
/packages/foundations/assets/icons/functional/fonts/**/*.ttf
/packages/foundations/assets/icons/functional/fonts/**/*.woff
/packages/foundations/assets/icons/functional/fonts/**/*.json
/packages/foundations/assets/icons/tmp/
/packages/foundations/assets/icons/fonts/**/index.html
/packages/foundations/assets/icons/fonts/**/index.css
/packages/foundations/assets/icons/fonts/**/font-face.css
/packages/foundations/assets/icons/fonts/**/info.json
/packages/foundations/assets/icons/fonts/**/*.eot
/packages/foundations/assets/icons/fonts/**/*.svg
/packages/foundations/assets/icons/fonts/**/*.ttf
/packages/foundations/assets/icons/fonts/**/*.woff
/packages/foundations/assets/icons/fonts/**/*.json
/packages/foundations/assets/icons/functional/**

/output/stencil/.stencil
/output/stencil/loader
Expand Down
2 changes: 1 addition & 1 deletion .xo-config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ module.exports = {
ignores: [
'./showcases/nuxt-showcase/**',
'./packages/migration/**',
'./packages/foundations/assets/**'
'./packages/foundations/**'
],
overrides: [
{
Expand Down
2 changes: 1 addition & 1 deletion docs/migration/alpha-beta.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
| 🔄 renamed `Tonality` to `Density` | class names and data-attributes changed from <br/>`.db-ui-#{$tonality},[data-tonality="#{$tonality}"] {` to <br/>`.db-#{density},[data-density="#{density}"] {` | search `tonality` & replace with `density` |
| ❌ removed `opacity` tokens | we use only 1 opacity (0.4) for all components | If you use some of the tokens like `--db-opacity-sm` you might run into issues with your layout |
| 🔄 updated `border` tokens | we add all shirt-sizes `3xs`-`3xl` as tokens | If you use some of the tokens like `db-border-height-sm` you might run into issues with your layout, because the values behind it changed |
| 🔄 moved `_font-sizes.scss` | We moved the file to another folder to align the same structure as icons or colors. We add `css` classes, you can use them by importing `@db-ui/foundations/scss/fonts/classes/all.css` | If you use some placeholder like `%db-overwrite-font-size-sm` you might need to import the `_font-sizes.scss` like this: `@use "@db-ui/foundations/build/scss/fonts";` |
| 🔄 moved `_font-sizes.scss` | We moved the file to another folder to align the same structure as icons or colors. We add `css` classes, you can use them by importing `@db-ui/foundations/scss/fonts/classes/all.css` | If you use some placeholder like `%db-overwrite-font-size-sm` you might need to import the `_font-sizes.scss` like this: `@use "@db-ui/foundations/build/scss/fonts";` |
| 🔄 ❗ refactored `colors` | All colors changed. We use color-palettes to generate speaking-names (check `@db-ui/foundations/scss/colors/_variables.scss` to see a list of available tokens). We removed `base` color, it was the same like `neutral`. Add different background level. | 1. Replace all `base` colors with `neutral`<br/>2. If you use the color class replace `db-bg-x` with `db-x-bg-lvl-1`<br/>3. Replace `border-strong`/ `border-weak` tokens with `contrast-high`/`contrast-low` |
| 🔄 renamed timing variables | renamed `$db-transition-emotional-timing` to `$db-transition-timing-emotional` / `--db-transition-emotional-timing` to `--db-transition-timing-emotional` | Replace `transition-emotional-timing` by `transition-timing-emotional` |

Expand Down
2 changes: 1 addition & 1 deletion output/react/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ import "@db-ui/components/build/styles/rollup.css";
```tsx
import { DBButton } from '@db-ui/react-components';
...
<DBButton icon="person" onClick={()=>{console.log("Test")}}>Test</DBButton>
<DBButton icon="x_placeholder" onClick={()=>{console.log("Test")}}>Test</DBButton>
...
```

Expand Down
2 changes: 1 addition & 1 deletion output/stencil/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ defineCustomElements();

```html
...
<db-button icon="person">Test</db-button>
<db-button icon="x_placeholder">Test</db-button>
...
```

Expand Down
2 changes: 1 addition & 1 deletion output/vue/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ import { DBButton } from "@db-ui/v-components";
</script>

<template>
<DBButton icon="person">Test</DBButton>
<DBButton icon="x_placeholder">Test</DBButton>
</template>
```

Expand Down
Loading
Loading