Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docstring for "catch all" relation type of External #215

Merged
merged 1 commit into from
May 15, 2024
Merged

Add docstring for "catch all" relation type of External #215

merged 1 commit into from
May 15, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

There was a question of what this type means. It was not the first time it was asked, and will not be the last.

Solution

Add a comment so this is clear.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this May 15, 2024
@mikealfare mikealfare requested a review from a team as a code owner May 15, 2024 19:48
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

VersusFacit
VersusFacit reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love docs. Changelog? 🌹

@mikealfare mikealfare added the Skip Changelog Skip changelog verification in a PR label May 15, 2024
@mikealfare mikealfare merged commit eda1095 into main May 15, 2024
15 of 17 checks passed
@mikealfare mikealfare deleted the add-helpful-comment-on-external-relation-type branch May 15, 2024 20:15
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Sep 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes The PR author has signed the CLA Skip Changelog Skip changelog verification in a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikealfare @VersusFacit