Show progress when querying env vars #42
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cloud_job.custom_environment_variables.append(env_var) | ||
| with Progress("Looping through jobs", BarColumn(), TaskProgressColumn(), TimeRemainingColumn(), console=console) as progress: | ||
| for cloud_job in progress.track(cloud_jobs): | ||
| logger.info(f"Getting en vars overwrites for the job {cloud_job.id}:{cloud_job.name}") |
There was a problem hiding this comment.
Should this be
Getting env vars overwrites for the job
vs.
Getting en vars overwrites for the job
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some actions can take longer than other, e.g. when we have to do one API call per job to get the env var overrides.
This change is a POC of how we could potentially show progress in the terminal.