Fixes-example-problems #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d into fixes-example-problems
|
I think that this is a good step forward and I am happy to merge it as-is. The only thing I did in addition was to do a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines some of the examples provided, to be more consistent in their resource naming.
It also allows for cleaner cut->paste into a single new main.tf script, to just generally work.
I also added an additional note at the top, where relevant, that further clarifies the "legacy provider" comment, as I found it a bit confusing at first, trying to understand if I needed to do something or not (not a legacy customer).
There is probably some additional work still to be done here, especially on the
import.shfront, making sure that aligns.