Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in examples for fabric credential #236

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fix typo in examples for fabric credential #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/resources/fabric_credential.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ description: |-

```terraform
# when using AD authentication
resource "dbtcloud_databricks_credential" "my_databricks_cred" {
resource "dbtcloud_fabric_credential" "my_fabric_cred_ad" {
project_id = dbtcloud_project.dbt_project.id
adapter_id = dbtcloud_fabric_connection.my_fabric_connection.adapter_id
schema = "my_schema"
Expand All @@ -24,7 +24,7 @@ resource "dbtcloud_databricks_credential" "my_databricks_cred" {
}

# when using service principal authentication
resource "dbtcloud_databricks_credential" "my_spark_cred" {
resource "dbtcloud_fabric_credential" "my_fabric_cred_serv_princ" {
project_id = dbtcloud_project.dbt_project.id
adapter_id = dbtcloud_fabric_connection.my_fabric_connection.adapter_id
schema = "my_schema"
Expand Down
3 changes: 1 addition & 2 deletions docs/resources/job.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ description: |-
Those improvements include modifications to deferral which was historically set at the job level and will now be set at the environment level.
Deferral can still be set to "self" by setting `self_deferring` to `true` but with the new approach, deferral to other runs need to be done with `deferring_environment_id` instead of `deferring_job_id`.


~> As of beginning of February 2024, job chaining with `job_completion_trigger_condition` is in private beta and not available to all users.
<br/>
<br/>
Expand Down Expand Up @@ -116,7 +115,7 @@ resource "dbtcloud_job" "downstream_job" {
- `execute_steps` (List of String) List of commands to execute for the job
- `name` (String) Job name
- `project_id` (Number) Project ID to create the job in
- `triggers` (Map of Boolean) Flags for which types of triggers to use, possible values are `github_webhook`, `git_provider_webhook`, `schedule` and `custom_branch_only`. <br>`custom_branch_only` is only relevant for CI jobs triggered automatically on PR creation to only trigger a job on a PR to the custom branch of the environment. To create a job in a 'deactivated' state, set all to `false`.
- `triggers` (Map of Boolean) Flags for which types of triggers to use, the values are `github_webhook`, `git_provider_webhook`, `schedule` and `custom_branch_only`. <br>`custom_branch_only` is only relevant for CI jobs triggered automatically on PR creation to only trigger a job on a PR to the custom branch of the environment. To create a job in a 'deactivated' state, set all to `false`.

### Optional

Expand Down
4 changes: 2 additions & 2 deletions examples/resources/dbtcloud_fabric_credential/resource.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# when using AD authentication
resource "dbtcloud_databricks_credential" "my_databricks_cred" {
resource "dbtcloud_fabric_credential" "my_fabric_cred_ad" {
project_id = dbtcloud_project.dbt_project.id
adapter_id = dbtcloud_fabric_connection.my_fabric_connection.adapter_id
schema = "my_schema"
Expand All @@ -9,7 +9,7 @@ resource "dbtcloud_databricks_credential" "my_databricks_cred" {
}

# when using service principal authentication
resource "dbtcloud_databricks_credential" "my_spark_cred" {
resource "dbtcloud_fabric_credential" "my_fabric_cred_serv_princ" {
project_id = dbtcloud_project.dbt_project.id
adapter_id = dbtcloud_fabric_connection.my_fabric_connection.adapter_id
schema = "my_schema"
Expand Down
Loading