Remove manual memory management to enhance memory safety

src/ABstats.cpp

@@ -24,11 +24,6 @@ ABstats::ABstats()
 }
 
 
-ABstats::~ABstats()
-{
-}
-
-
 void ABstats::Reset()
 {
   for (int depth = 0; depth < DDS_MAXDEPTH; depth++)

src/ABstats.h

@@ -106,7 +106,7 @@ class ABstats
 
     ABstats();
 
-    ~ABstats();
+    ~ABstats() = default;
 
     void Reset();
 

src/Memory.cpp

@@ -11,21 +11,10 @@
 #include "Memory.h"
 
 
-Memory::Memory()
-{
-}
-
-
-Memory::~Memory()
-{
-  Memory::Resize(0, DDS_TT_SMALL, 0, 0);
-}
-
-
 void Memory::ReturnThread(const unsigned thrId)
 {
-  memory[thrId]->transTable->ReturnAllMemory();
-  memory[thrId]->memUsed = Memory::MemoryInUseMB(thrId);
+  memory[thrId].transTable->ReturnAllMemory();
+  memory[thrId].memUsed = Memory::MemoryInUseMB(thrId);
 }
 
 
@@ -40,12 +29,6 @@ void Memory::Resize(
 
   if (memory.size() > n)
   {
-    // Downsize.
-    for (unsigned i = n; i < memory.size(); i++)
-    {
-      delete memory[i]->transTable;
-      delete memory[i];
-    }
     memory.resize(static_cast<unsigned>(n));
     threadSizes.resize(static_cast<unsigned>(n));
   }
@@ -57,22 +40,21 @@ void Memory::Resize(
     threadSizes.resize(n);
     for (unsigned i = oldSize; i < n; i++)
     {
-      memory[i] = new ThreadData();
       if (flag == DDS_TT_SMALL)
       {
-        memory[i]->transTable = new TransTableS;
+        memory[i].transTable.reset(new TransTableS);
         threadSizes[i] = "S";
       }
       else
       {
-        memory[i]->transTable = new TransTableL;
+        memory[i].transTable.reset(new TransTableL);
         threadSizes[i] = "L";
       }
 
-      memory[i]->transTable->SetMemoryDefault(memDefault_MB);
-      memory[i]->transTable->SetMemoryMaximum(memMaximum_MB);
+      memory[i].transTable->SetMemoryDefault(memDefault_MB);
+      memory[i].transTable->SetMemoryMaximum(memMaximum_MB);
 
-      memory[i]->transTable->MakeTT();
+      memory[i].transTable->MakeTT();
     }
   }
 }
@@ -91,13 +73,13 @@ ThreadData * Memory::GetPtr(const unsigned thrId)
     cout << "Memory::GetPtr: " << thrId << " vs. " << memory.size() << endl;
     exit(1);
   }
-  return memory[thrId];
+  return &memory[thrId];
 }
 
 
 double Memory::MemoryInUseMB(const unsigned thrId) const
 {
-  return memory[thrId]->transTable->MemoryInUse() +
+  return memory[thrId].transTable->MemoryInUse() +
     8192. * sizeof(relRanksType) / static_cast<double>(1024.);
 }
 

src/Memory.h

@@ -10,6 +10,7 @@
 #ifndef DDS_MEMORY_H
 #define DDS_MEMORY_H
 
+#include <memory>
 #include <vector>
 
 #include "TransTable.h"
@@ -78,7 +79,7 @@ struct ThreadData
   // 960 KB
   relRanksType rel[8192];
 
-  TransTable * transTable;
+  std::unique_ptr<TransTable> transTable;
 
   Moves moves;
 
@@ -116,16 +117,12 @@ class Memory
 {
   private:
 
-    vector<ThreadData *> memory;
+    vector<ThreadData> memory;
 
     vector<string> threadSizes;
 
   public:
 
-    Memory();
-
-    ~Memory();
-
     void ReturnThread(const unsigned thrId);
 
     void Resize(

src/Moves.cpp

@@ -97,11 +97,6 @@ Moves::Moves()
 }
 
 
-Moves::~Moves()
-{
-}
-
-
 void Moves::Init(
   const int tricks,
   const int relStartHand,

src/Moves.h

@@ -176,7 +176,7 @@ class Moves
   public:
     Moves();
 
-    ~Moves();
+    ~Moves() = default;
 
     void Init(
       const int tricks,

src/Scheduler.cpp

@@ -85,11 +85,6 @@ void Scheduler::InitTimes()
 #endif
 
 
-Scheduler::~Scheduler()
-{
-}
-
-
 void Scheduler::Reset()
 {
   for (int b = 0; b < MAXNOOFBOARDS; b++)

src/Scheduler.h

@@ -162,7 +162,7 @@ class Scheduler
 
     Scheduler();
 
-    ~Scheduler();
+    ~Scheduler() = default;
 
     void RegisterThreads(
       const int n);

src/System.cpp

@@ -83,11 +83,6 @@ System::System()
 }
 
 
-System::~System()
-{
-}
-
-
 void System::Reset()
 {
   runCat = DDS_RUN_SOLVE;
@@ -434,19 +429,16 @@ int System::RunThreadsGCD()
 int System::RunThreadsBoost()
 {
 #ifdef DDS_THREADS_BOOST
-  vector<boost::thread *> threads;
+  vector<boost::thread> threads;
 
   const unsigned nu = static_cast<unsigned>(numThreads);
-  threads.resize(nu);
+  threads.reserve(nu);
 
   for (unsigned k = 0; k < nu; k++)
-    threads[k] = new boost::thread(fptr, k);
+    threads.emplace_back(fptr, k);
 
-  for (unsigned k = 0; k < nu; k++)
-  {
-    threads[k]->join();
-    delete threads[k];
-  }
+  for (boost::thread & t : threads)
+    t.join();
 #endif
 
   return RETURN_NO_FAULT;
@@ -460,23 +452,20 @@ int System::RunThreadsBoost()
 int System::RunThreadsSTL()
 {
 #ifdef DDS_THREADS_STL
-  vector<thread *> threads;
+  vector<thread> threads;
 
   vector<int> uniques;
   vector<int> crossrefs;
   (* CallbackDuplList[runCat])(* bop, uniques, crossrefs);
 
   const unsigned nu = static_cast<unsigned>(numThreads);
-  threads.resize(nu);
+  threads.reserve(nu);
 
   for (unsigned k = 0; k < nu; k++)
-    threads[k] = new thread(fptr, k);
+    threads.emplace_back(fptr, k);
 
-  for (unsigned k = 0; k < nu; k++)
-  {
-    threads[k]->join();
-    delete threads[k];
-  }
+  for (thread & t : threads)
+    t.join();
 #endif
 
   return RETURN_NO_FAULT;
@@ -534,19 +523,16 @@ int System::RunThreadsSTLIMPL()
 int System::RunThreadsTBB()
 {
 #ifdef DDS_THREADS_TBB
-  vector<tbb::tbb_thread *> threads;
+  vector<tbb::tbb_thread> threads;
 
   const unsigned nu = static_cast<unsigned>(numThreads);
-  threads.resize(nu);
+  threads.reserve(nu);
 
   for (unsigned k = 0; k < nu; k++)
-    threads[k] = new tbb::tbb_thread(fptr, k);
+    threads.emplace_back(fptr, k);
 
-  for (unsigned k = 0; k < nu; k++)
-  {
-    threads[k]->join();
-    delete threads[k];
-  }
+  for (tbb::tbb_thread & t : threads)
+    t.join();
 #endif
 
   return RETURN_NO_FAULT;

src/System.h

@@ -81,7 +81,7 @@ class System
   public:
     System();
 
-    ~System();
+    ~System() = default;
 
     void Reset();
 

src/ThreadMgr.cpp

@@ -29,11 +29,6 @@ ThreadMgr::ThreadMgr()
 }
 
 
-ThreadMgr::~ThreadMgr()
-{
-}
-
-
 void ThreadMgr::Reset(const int nThreads)
 {
   const unsigned n = static_cast<unsigned>(nThreads);

src/ThreadMgr.h

@@ -29,7 +29,7 @@ class ThreadMgr
 
     ThreadMgr();
 
-    ~ThreadMgr();
+    ~ThreadMgr() = default;
 
     void Reset(const int nThreads);
 

src/TimeStat.cpp

@@ -22,11 +22,6 @@ TimeStat::TimeStat()
 }
 
 
-TimeStat::~TimeStat()
-{
-}
-
-
 void TimeStat::Reset()
 {
   number = 0;

src/TimeStat.h

@@ -27,7 +27,7 @@ class TimeStat
 
     TimeStat();
 
-    ~TimeStat();
+    ~TimeStat() = default;
 
     void Reset();
 

src/TimeStatList.cpp

@@ -15,17 +15,6 @@
 #include "TimeStatList.h"
 
 
-TimeStatList::TimeStatList()
-{
-  TimeStatList::Reset();
-}
-
-
-TimeStatList::~TimeStatList()
-{
-}
-
-
 void TimeStatList::Reset()
 {
 }

src/TimeStatList.h

@@ -28,10 +28,6 @@ class TimeStatList
 
   public:
 
-    TimeStatList();
-
-    ~TimeStatList();
-
     void Reset();
 
     void Init(

src/Timer.cpp

@@ -24,11 +24,6 @@ Timer::Timer()
 }
 
 
-Timer::~Timer()
-{
-}
-
-
 void Timer::Reset()
 {
   name = "";

src/Timer.h

@@ -35,7 +35,7 @@ class Timer
 
     Timer();
 
-    ~Timer();
+    ~Timer() = default;
 
     void Reset();
 

src/TimerGroup.cpp

@@ -22,11 +22,6 @@ TimerGroup::TimerGroup()
 }
 
 
-TimerGroup::~TimerGroup()
-{
-}
-
-
 void TimerGroup::Reset()
 {
   timers.resize(TIMER_DEPTH);

src/TimerGroup.h

@@ -29,7 +29,7 @@ class TimerGroup
 
     TimerGroup();
 
-    ~TimerGroup();
+    ~TimerGroup() = default;
 
     void Reset();