Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VR Render Type #296

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support VR Render Type #296

wants to merge 1 commit into from

Conversation

s4t0
Copy link

@s4t0 s4t0 commented Nov 3, 2022

No description provided.

@menduz menduz requested a review from sicarul November 3, 2022 22:49
@menduz
Copy link
Member

menduz commented Nov 3, 2022

@sicarul could you take a look at this?

sicarul
sicarul approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@sicarul sicarul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally and checked the code and it looks good to me!

Remember to add VR_TYPE in the URL as discussed, thanks!

@sicarul
Copy link
Contributor

sicarul commented Nov 4, 2022

@s4t0 Please sign your commits with GPG: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@sicarul
Copy link
Contributor

sicarul commented Nov 9, 2022

LGTM, can you merge @menduz ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sicarul sicarul sicarul approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
stream-discoverability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@s4t0 @menduz @sicarul @xavi-dcl