Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Login with auth server page #417

Merged
merged 20 commits into from
Dec 28, 2023
Merged

feat: Login with auth server page #417

merged 20 commits into from
Dec 28, 2023

Conversation

fzavalia
Copy link
Contributor

@fzavalia fzavalia commented Dec 28, 2023

Integrates the sign in flow with the auth dapp into the explorer website, only for the desktop version.

The feature is behind the dapps-desktop-client-with-auth-dapp which is to be toggled when the feature is ready.

The flow is:

  • User opens desktop client
  • User views the welcome page
  • User clicks on START
  • If the user has already signed in
    • The user enters the game with the already signed in account.
  • If not
    • The user sees the code
    • The user clicks on CONTINUE TO SIGN IN
    • The auth dapp will open in the user browser.
    • If the request to sign in expires
      • The user will see the expired screen
    • If not
      • The game will open with the account the user signed in on the auth dapp
Screenshot 2023-12-28 at 11 51 57 Screenshot 2023-12-28 at 11 52 38 Screenshot 2023-12-28 at 11 54 02

Copy link

Test this pull request

This branch can be previewed at

Copy link
Contributor

@LautaroPetaccio LautaroPetaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I've left some comments to review but it should be ready to go afterwards.

package.json Outdated Show resolved Hide resolved
src/components/auth/LoginWithAuthServerPage.tsx Outdated Show resolved Hide resolved
@fzavalia fzavalia merged commit 675b180 into main Dec 28, 2023
3 checks passed
@fzavalia fzavalia deleted the feat/integrate-auth-server branch December 28, 2023 19:08
fzavalia added a commit that referenced this pull request Dec 28, 2023
fzavalia added a commit that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants