vspd: Move config to internal package. #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the derived config values, which are not exported, to still be accessed after config.go is moved to the internal vspd package.
This enables the config to be reused in multiple binaries - eg. the upcoming vsp admin binary which will be responsible for writing a default config file for new vspd deployments.
davecgh
approved these changes
May 29, 2024
Returning a single struct which contains multiple named fields reduces the chance of a mistake in the calling code, as compared to returning multiple unnamed values which are all of the same type.
davecgh
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the config to be reused in multiple binaries - eg. the upcoming vsp admin binary which will be responsible for writing a default config file for new vspd deployments.