Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: upload more files #132

Merged
merged 6 commits into from
Nov 7, 2023
Merged

tests: upload more files #132

merged 6 commits into from
Nov 7, 2023

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Nov 7, 2023

Related Issues

  • fixes #issue-number

Proposed Changes?

  • upload enough files to satisfy test_list_all_files test

How did you test it?

Notes for the reviewer

Screenshots (optional)

Screenshot 2023-11-07 at 10 54 52

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

Copy link

github-actions bot commented Nov 7, 2023

Coverage report

The coverage rate went from 92.9% to 92.9% ⬆️
The branch rate is 80%.

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need more files ?

tests/conftest.py Show resolved Hide resolved
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh saw your screenshot

@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue Nov 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2023
@wochinge wochinge enabled auto-merge November 7, 2023 10:23
@wochinge wochinge added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit 15a335e Nov 7, 2023
9 checks passed
@wochinge wochinge deleted the tests/more-files branch November 7, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants