-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ByteStream auto mime_type detection and base64 (de)encoding #157
base: main
Are you sure you want to change the base?
feat: ByteStream auto mime_type detection and base64 (de)encoding #157
Conversation
9dcaa6b
to
7fd1212
Compare
Hey @LastRemote - thank you for your excellent work on the multimodal ChatMessage updates! As we inch closer to Haystack 2.9 release, we’ll be focusing on tooling changes to ChatMessage. These updates will require careful coordination to ensure nothing breaks. Here’s the proposed plan:
Your efforts on this front are deeply appreciated 🙏 |
@vblagoje Sure thing, my intention is to make all the multimodal changes in experimental first. I already did some complicated E2E/unit testing with images and tool calls on my end, but I would prefer taking smaller steps at a time. P.S. I just made a personal project that utilizes complicated tools and memory interactions. Happy to share more information, but I will need to clean up my code a bit first. |
That would be great @LastRemote - we are also seeing a lot of demand for tools and memory - it would be great to bounce ideas back and forth 🙏 |
Hey @vblagoje , any guidance on how to fix the lint error? Not sure what exactly I need to do here. Btw the unit test failures seem to be unrelated. |
Related Issues
Proposed Changes:
This PR is a part of #145 in the attempt to add multi-modal support in Haystack generators.
ByteStream: auto mime_type detection when loading a file
ByteStream: support the encoding and decoding process in base64
How did you test it?
unit tests completed. E2E multimodal tests with other parts (WIP) completed.
Notes for the reviewer
Limitation: currently we still do not have a load_from_url method or something equivalent to utilize image_url when calling LLM.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.