Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix format after newly introduced formatting rules from ruff release #8696

Merged
merged 1 commit into from
Jan 9, 2025
Merged

CI: fix format after newly introduced formatting rules from ruff release #8696

merged 1 commit into from
Jan 9, 2025

Conversation

mathislucka
Copy link
Member

Related Issues

  • fixes #issue-number

Proposed Changes:

How did you test it?

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mathislucka mathislucka requested a review from a team as a code owner January 9, 2025 16:11
@mathislucka mathislucka requested review from mpangrazzi and removed request for a team January 9, 2025 16:11
@mathislucka mathislucka added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jan 9, 2025
julian-risch
julian-risch approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thank you!

@julian-risch julian-risch enabled auto-merge (squash) January 9, 2025 16:15
@julian-risch julian-risch merged commit fe9b1e2 into main Jan 9, 2025
16 of 17 checks passed
@julian-risch julian-risch deleted the fix/new_ruff_release_format branch January 9, 2025 16:25
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12693905292

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage remained the same at 91.094%
Files with Coverage Reduction New Missed Lines %
components/converters/openapi_functions.py 1 78.63%
marshal/yaml.py 1 95.24%
document_stores/in_memory/document_store.py 7 96.03%
Totals Coverage Status
Change from base Build 12689025274: 0.0%
Covered Lines: 8653
Relevant Lines: 9499
💛 - Coveralls

julian-risch pushed a commit that referenced this pull request Jan 9, 2025
@mathislucka @julian-risch
CI: fix format after newly introduced formatting rules from ruff rele…
d3b39b7 
…ase (#8696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

@mpangrazzi mpangrazzi Awaiting requested review from mpangrazzi mpangrazzi is a code owner automatically assigned from deepset-ai/open-source-engineering

Assignees
No one assigned
Labels
ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:core topic:tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathislucka @coveralls @julian-risch