chore: update transformers test dependency
#8752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anakin87
added
the
ignore-for-release-notes
Pull Request Test Coverage Report for Build 12873461371Details
💛 - Coveralls |
anakin87
commented
Jan 20, 2025
| @@ -42,6 +42,7 @@ def mock_pipeline_tokenizer(): | |||
| # Mocking the tokenizer | |||
| mock_tokenizer = Mock(spec=PreTrainedTokenizer) | |||
| mock_tokenizer.encode.return_value = ["Berlin", "is", "cool"] | |||
| mock_tokenizer.pad_token_id = 100 | |||
There was a problem hiding this comment.
PreTrainedTokenizer in new versions of transformers does not have a default pad_token_id, so I'm setting it in the Mock.
(In any case, we are confident that our component works properly also thanks to an integration test.)
| stop_words_criteria = StopWordsCriteria(tokenizer=Mock(spec=PreTrainedTokenizerFast), stop_words=["mock data"]) | ||
|
|
||
| mock_tokenizer = Mock(spec=PreTrainedTokenizerFast) | ||
| mock_tokenizer.pad_token = "<pad>" |
| @@ -459,3 +463,15 @@ def test_hf_pipeline_runs_with_our_criteria(self): | |||
| results = generator.run(prompt="something that triggers something") | |||
| assert results["replies"] != [] | |||
| assert generator.stopping_criteria_list is not None | |||
|
|
|||
| @pytest.mark.integration | |||
There was a problem hiding this comment.
I also added an integration test with a small model: it was missing and it helps to make sure everything works...
mpangrazzi
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
transformersin the CIProposed Changes:
transformerstest dependency to 4.47.1How did you test it?
CI
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.